Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc bug fixes and minor UX improvements #427

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Misc bug fixes and minor UX improvements #427

merged 7 commits into from
Oct 16, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Oct 15, 2024 •
edited
Loading

Description

General PR with a variety of bug fixes and minor UX improvements.

  • tunes wording on input transform (ingest)
  • fixes bug of error modal persisting even when removing the JSON file on import
  • stretches filepicker to span across modal body on import
  • rearrange create/skip ingest pipeline radio group
  • make entire form scrollable
  • increase scrollable form margins
  • tune wording related to the source/input data
  • only show the docs if there is valid/populated values. Show last ingested timestamp after successful ingestion on-the-fly. Note we don't persist this such that a page refresh will show this still, as we have no way to track when the last ingestion occurred. The workflow timestamps only persist last updated, but users can later only edit the search-related components, which would update this timestamp, but not be related to the last time of ingestion.

Demo video highlighting changes:

screen-capture.9.webm

Issues Resolved

--

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler added bug Something isn't working enhancement New feature or request backport 2.x v2.18.0 labels Oct 15, 2024
@ohltyler ohltyler marked this pull request as draft October 15, 2024 22:14
@ohltyler ohltyler marked this pull request as ready for review October 16, 2024 18:54
@ohltyler ohltyler merged commit 1f449af into opensearch-project:main Oct 16, 2024
6 checks passed
@ohltyler ohltyler deleted the bugs-1 branch October 16, 2024 19:55
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 16, 2024
@github-actions
Misc bug fixes and minor UX improvements (#427)
268ca8d 
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 1f449af)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 16, 2024
Merged
ohltyler pushed a commit that referenced this pull request Oct 16, 2024
@opensearch-trigger-bot @github-actions
Misc bug fixes and minor UX improvements (#427) (#429)
2aab2ff 
(cherry picked from commit 1f449af)

Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ohltyler ohltyler mentioned this pull request Oct 18, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saimedhi saimedhi saimedhi approved these changes

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

@minalsha minalsha Awaiting requested review from minalsha minalsha is a code owner

Assignees
No one assigned
Labels
backport 2.x bug Something isn't working enhancement New feature or request v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ohltyler @saimedhi